Skip to content

Conversation

@bsod90
Copy link
Member

@bsod90 bsod90 commented Oct 29, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@bsod90 bsod90 requested a review from a team as a code owner October 29, 2024 16:54
@vercel
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:13pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:13pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:13pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:13pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:13pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:13pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:13pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:13pm

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 29, 2024
@bsod90 bsod90 requested a review from ovr October 29, 2024 16:55
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥔 🔥 🚀

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.50%. Comparing base (fa4b3b8) to head (94c1d9e).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8880      +/-   ##
==========================================
- Coverage   82.50%   82.50%   -0.01%     
==========================================
  Files         221      221              
  Lines       77597    77602       +5     
==========================================
+ Hits        64022    64024       +2     
- Misses      13575    13578       +3     
Flag Coverage Δ
cubesql 82.50% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsod90 bsod90 force-pushed the fix_rbac_python_config branch from 58da503 to 94c1d9e Compare October 29, 2024 17:12
@bsod90 bsod90 merged commit aadce4f into master Oct 29, 2024
73 checks passed
@bsod90 bsod90 deleted the fix_rbac_python_config branch October 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants